Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resourcegroup): add tag feature for networkwatcherrg #421

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wetwicky
Copy link

Overview/summary

Allow configuring tags on networkWatcher resource group by using an optional variable which default to an empty map. fixes

This feature is practical for scenario where tags are inherited from subscription using azure policies

Testing evidence

without this modification, terraform would always detect drift (if azure policies modify the tags).

allowing to set tag on networkWatcher resource group using an input variable

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence.
  • Updated relevant and associated documentation.

@wetwicky wetwicky changed the title Add tag feature for networkwatcher RG feat(Network): Add tag feature for networkwatcher RG Sep 26, 2024
@wetwicky wetwicky changed the title feat(Network): Add tag feature for networkwatcher RG feat(resourcegroup): Add tag feature for networkwatcher RG Sep 26, 2024
@wetwicky wetwicky changed the title feat(resourcegroup): Add tag feature for networkwatcher RG feat(resourcegroup): add tag feature for networkwatcherrg Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant