fix: use correct budget parameters #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @steph409 Thank you so much for this fix - I think it has been reverted in your latest commit as I can only see one file changed. Can you please check? |
|
ah yes you are right, i just changed the readme and not the variables file, fixed! |
matt-FFFFFF
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/summary
fixes issue #394
The wrong parameter was used in the notification budgets.
The description for the parameters is correct, but the example is wrong.
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking changes
None, only docu change
Testing evidence
Please provide testing evidence to show that your Pull Request works/fixes as described and documented above.
As part of this pull request I have
make fmt&make docsto format your code and update documentation.