Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription display name & alias validation rule #374

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

kewalaka
Copy link
Contributor

@kewalaka kewalaka commented May 4, 2024

Overview/summary

Updates the validation rule to align with the hashicorp provider code.

This PR fixes/adds/changes/removes

  1. fixes bug: incorrect validation on subscription display name #373

Breaking changes

No.

Testing evidence

Deployed into a sub with brackets in the name.

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence.
  • Updated relevant and associated documentation.

@kewalaka kewalaka requested a review from a team as a code owner May 4, 2024 03:04
@matt-FFFFFF
Copy link
Member

Thank you for this! The REST API specs are not forthcoming, so happy to relax this I think.

@matt-FFFFFF
Copy link
Member

image

matt-FFFFFF
matt-FFFFFF previously approved these changes Jun 5, 2024
Merged via the queue into Azure:main with commit b51493f Jun 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run deployment tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect validation on subscription display name
2 participants