Fixing globs in routes #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
requested review from
manekinekko,
v1212,
cjk7989 and
IvanJobs
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -31,7 +31,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| return glob.replace(/\//g, "\\/").replace("*.", ".*").replace("/*", "/.*"); | |||
| return glob.replace(/\//g, "\\/").replace(".", "\\.").replace("*", ".*"); | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
| @@ -31,7 +31,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| return glob.replace(/\//g, "\\/").replace("*.", ".*").replace("/*", "/.*"); | |||
| return glob.replace(/\//g, "\\/").replace(".", "\\.").replace("*", ".*"); | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the behavior of the
globToRegExpfunction in thesrc/core/utils/glob.tsfile. The function now correctly interprets the*character as a wildcard and escapes the.character to match a literal dot. Additionally, the expected result in the test case forglobToRegExpwas modified to reflect the updated behavior of the function.Main changes:
src/core/utils/glob.ts: Modified theglobToRegExpfunction to correctly interpret the*character as a wildcard and escape the.character to match a literal dot.src/core/utils/glob.spec.ts: Modified the expected result in the test case forglobToRegExpto include the escaped dot character (\.) to match the updated behavior of the function.Fixes #792