feat(telemetry): Pushed changes to optimise the delay after the process end… #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to calculate configfileOptions
rupareddy5-21
requested review from
manekinekko,
sgollapudi77 and
sulabh-msft
as code owners
sulabh-msft
reviewed
Apr 25, 2023
src/cli/commands/start/start.ts
Outdated
| @@ -30,7 +30,7 @@ export async function start(options: SWACLIConfig) { | |||
| // Make sure this code (or code from utils) does't depend on environment variables! | |||
|
|
|||
| const cmdStartTime = new Date().getTime(); | |||
| const flagsUsed = getFlagsUsed(options); | |||
| const flagsUsed = getFlagsUsed(options, "start"); | |||
There was a problem hiding this comment.
Do we have constant to use here SWACommand ?
There was a problem hiding this comment.
The Type SWACommand cant be used as a value here.
sulabh-msft
reviewed
Apr 25, 2023
| @@ -92,7 +92,7 @@ export async function start(options: SWACLIConfig) { | |||
| else if (!fs.existsSync(outputLocation!)) { | |||
| logger.error(`The folder "${resolvedOutputLocation}" is not found. Exit.`, true); | |||
| const cmdEndTime = new Date().getTime(); | |||
| collectTelemetryEvent(TELEMETRY_EVENTS.Start, { | |||
| await collectTelemetryEvent(TELEMETRY_EVENTS.Start, { | |||
There was a problem hiding this comment.
so collectTelemetryEvent is async call
sulabh-msft
reviewed
Apr 25, 2023
src/core/utils/options.ts
Outdated
| "outputLocation", | ||
| "apiLocation", | ||
| "appDevserverUrl", | ||
| "apiDevserverUrl", |
There was a problem hiding this comment.
Why do we need this hard coding?
not sure if this scalable.. is there a way to build this list dynamically from the these commands code?
sulabh-msft
reviewed
Apr 25, 2023
| @@ -90,6 +90,7 @@ export class BaseTelemetrySender implements TelemetrySender { | |||
| this._telemetryClient = client; | |||
| this._instantiationStatus = InstantiationStatus.INSTANTIATED; | |||
| this._flushQueues(); | |||
| this._telemetryClient.flush(); | |||
There was a problem hiding this comment.
can we please check if flush is async and do we need to await() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and to calculate configfileOptions