Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alz_checklist.en.json #746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update alz_checklist.en.json #746

wants to merge 1 commit into from

Conversation

mbilalamjad
Copy link
Contributor

Adding a check to help Architects/Engineers have an overall conversation on the encryption on Azure with customers. This is based on feedback we received.

@mbilalamjad mbilalamjad requested review from a team as code owners April 25, 2024 19:55
{
"category": "Security",
"subcategory": "Encryption and keys",
"text": "Consider planning for encryption at rest and in transit for all data along with key management in Azure.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this into something that is more of a review item?

Something like "Configure encryption at rest and in transit on Key Vaults" and then linking to that specific setting. A really broad "consideration" item probably isn't the best kind of item for the check list. We are trying to capture guide lines for this here: https://github.com/Azure/review-checklists/blob/main/CONTRIBUTING.md#what-to-contribute

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scope of services would be quite limited for recommendation purposes, we could add 1 or many specific ones. E.g;
Use Azure disk encryption or encryption at host for your IaaS workloads

Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want guidance for IaaS workloads to be in the Landing Zone checklist?

We've talked off an on about how to handle these - should we have a separate "IaaS workload" checklist for the actual application landing zones, so that this can be geared to the Platform landing zone (and be focused on the policies deployed to govern that across workloads).

I think it gives us a smaller list here if we are focused on the Platform landing zone items specifically, and then more general IaaS or migration items could be in their own checklists. However, does that work with how this is used from in practice from the broader team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, the feedback we got was that there are no checks/guidance around encryption, and it was highlighted as a gap.

Might be worth having a meeting and taking this offline for a discussion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workshop text:

Deploy policies to workload subscription management groups to manage encryption at rest on resources that support it, such as managed disk encryption and enabling TDE on SQL instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants