fix configure-values.sh missing AZURE_SUBSCRIPTION_ID #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmod +x ./configure-values.sh && ./configure-values.sh ${CLUSTER_NAME} ${RG} karpenter-sa karpentermsi
Configuring karpenter-values.yaml for cluster karpenter in resource group karpenter ...
Error: variable ${AZURE_SUBSCRIPTION_ID} not set
configure-values.sh missing AZURE_SUBSCRIPTION_ID, fix this bug.
…sing-subid Update configure-values.sh
fix configure-values.sh missing AZURE_SUBSCRIPTION_ID
tallaxes
approved these changes
May 11, 2024
Pull Request Test Coverage Report for Build 9124054480Details
💛 - Coveralls |
Bryce-Soghigian
approved these changes
May 13, 2024
Bryce-Soghigian
approved these changes
May 17, 2024
|
triggering tests again and we can get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
ottodeng@karpenter-client:~$ chmod +x ./configure-values.sh && ./configure-values.sh ${CLUSTER_NAME} ${RG} karpenter-sa karpentermsi
Configuring karpenter-values.yaml for cluster karpenter in resource group karpenter ...
Error: variable ${AZURE_SUBSCRIPTION_ID} not set
How was this change tested?
ottodeng@karpenter-client:~$ chmod +x ./configure-values.sh && ./configure-values.sh ${CLUSTER_NAME} ${RG} karpenter-sa karpentermsi
Configuring karpenter-values.yaml for cluster karpenter in resource group karpenter ...
Does this change impact docs?
Release Note