Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure CNI Overlay support for BYO Subnet #314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bryce-Soghigian
Copy link
Contributor

@Bryce-Soghigian Bryce-Soghigian commented Apr 29, 2024

Fixes #

Description
This PR adds support for BYO subnet for AzureCNI Overlay Clusters. It removes the instance provider subnetID reference and instead resolves the value from launch template parameters.

How was this change tested?

  • Additional Test Coverage
  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Support for Per Nodeclass BYO Subnet

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8978512476

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 97.769%

Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 8905676791: -0.005%
Covered Lines: 36282
Relevant Lines: 37110

💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review May 7, 2024 02:00
Copy link
Contributor Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian
Copy link
Contributor Author

WARNING: docker_bridge_cidr is not a known attribute of class <class 'azure.mgmt.containerservice.v2024_01_01.models._models_py3.ContainerServiceNetworkProfile'> and will be ignored
ERROR: (EntityStoreOperationError) Failed to save control plane with ID 66398ca8261b450001b56f69. A database operation failed. Please retry later. If this error persists, contact AKS support.
Code: EntityStoreOperationError
Message: Failed to save control plane with ID 66398ca8261b450001b56f69. A database operation failed. Please retry later. If this error persists, contact AKS support.

@Bryce-Soghigian
Copy link
Contributor Author

Assuming my e2es are failing for unrelated reasons

@Bryce-Soghigian Bryce-Soghigian self-assigned this May 7, 2024
Copy link
Contributor Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants