fix: don't use untagged on ksnap acr purge #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8870866309Details
💛 - Coveralls |
tallaxes
added
kind/bug
| var purgeOldArtifacts = ''' | ||
| version: v1.1.0 | ||
| steps: | ||
| - cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d --untagged | ||
| - cmd: acr purge --filter 'karpenter/snapshot/.*:.*' --ago 30d |
There was a problem hiding this comment.
this will remove any image that is older than 30 days for snapshot images?
I also read about dry run we could use to test some of this if we wanted to add tests for this kind of thing.
--dry-run - Specifies that no data is deleted, but the output is the same as if the command is run without this flag. This parameter is useful for testing a purge command to make sure it does not inadvertently delete data you intend to preserve.
There was a problem hiding this comment.
this will remove any image that is older than 30 days for snapshot images?
Yes
--dry-run
Yes, though I'd prefer to check the results of the actual execution instead; don't quite trust --dry-run at this point
Bryce-Soghigian
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Don't use
--untaggedon ksnap acr purge, as it appears to be broken: Azure/acr-cli#131How was this change tested?
Does this change impact docs?
Release Note