Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(best practices): add best practices doc #171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description
We've had discussions on multiple points which I think need defined guidance, and best practices.

This is adding a living doc that will be built out with best practices we develop with, and build off of.

How was this change tested?
NA
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 8100015433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.686%

Totals Coverage Status
Change from base Build 8070761721: 0.0%
Covered Lines: 35594
Relevant Lines: 36437

💛 - Coveralls

## versioning

- We should never drift further than one minor version behind sigs.k8s.io/karpenter
- We can have commit version references in-between our releases, but for any `karpenter-provider-azure` release we will tie ourselves down to a whole version of `sigs.k8s.io/karpenter`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires more thought, and development of our release cadence and slo before we can make a decision

@Bryce-Soghigian
Copy link
Contributor

Would love for us to get back to this, maybe this can be brought up in working group as well for the azure docs working group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants