Proposal for Scaler APIs discovery in extension #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrod
changed the title
alrod
changed the title
mathewc
reviewed
Oct 17, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 17, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 17, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 17, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 19, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 19, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 19, 2023
test/Microsoft.Azure.WebJobs.Host.EndToEndTests/Scale/ScaleHostEndToEndTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 24, 2023
| Configuration = context.Configuration, | ||
| EnvironmentName = context.HostingEnvironment.EnvironmentName | ||
| }; | ||
| webJobsBuilderContext.Properties["IsAzureWebJobsScaleHost"] = true; |
There was a problem hiding this comment.
Still considering the best way to flow this property. An alternative might be to add the "context" HostBuilderContext in this scope as a property on WebJobsBuilderContext. We could then leverage the Property collection of that type, and could also set this flag automatically in ConfigureWebJobsScale.
mathewc
reviewed
Oct 24, 2023
| public TestExtensionScalerProvider(IConfiguration config, IOptions<ScaleOptions> scaleOptions, TriggerMetadata triggerMetadata) | ||
| public void Configure(WebJobsBuilderContext context, IWebJobsBuilder builder) | ||
| { | ||
| if (context.Properties.ContainsKey("IsAzureWebJobsScaleHost")) |
There was a problem hiding this comment.
Still thinking what helper we could add to simplify this Properties check - e.g. an IsScaleHost extension method somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.