Time calls to flush, close and complete to accurately measure I/O time #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing timer logs seemingly undercount the time taken to write to Blob storage, likely because of ongoing buffering and some pending operations that complete after flush/close which are not being accounted for in the timer. This PR times flush/close/complete methods also to more accurately measure the entire time spent in I/O.
goiri
approved these changes
Apr 8, 2021
|
@pragnagopa please review whenever you get a chance. Thanks a lot. |
|
@pragnagopa is this something we still need, can you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing timer logs seemingly undercount the time taken to write to Blob storage, likely because of ongoing buffering and some pending operations that complete after flush/close which are not being accounted for in the timer.
This PR times flush/close/complete methods also to more accurately measure the entire time spent in I/O.