Handle MsiTokenResponse::expires_on being an int or string. #2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tot0
requested review from
heaths,
RickWinter,
JeffreyRichter and
LarryOsterman
as code owners
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
|
@chlowell I will review the PR, but I leave it up to you if you want to take it for Identity. We already have code that handles this (see the |
heaths
approved these changes
Mar 26, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
heaths
added
the
customer-reported
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
chlowell
added a commit
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MSI token servers don't follow the spec and return
expires_onas an int unix timestamp, rather than the expected string of an int unix timestamp, so to be broadly compatible it's nice to handle both.