Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue #37464 #39534

Merged
merged 17 commits into from
Feb 5, 2025
Merged

GitHub issue #37464 #39534

merged 17 commits into from
Feb 5, 2025

Conversation

achauhan-scc
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

@vizhur vizhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would oppose that feature in general. For various reasons, no anonymous assets should be in the registry. (probably not a client concern)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@achauhan-scc
Copy link
Member Author

@vizhur - This PR is not to enable/disable anonymous environment, it's to gracefully handle an error while uploading build context to registry.
Currently its throwing unrelated error. (because when upload fails, it tries to upload to workspace default datastore, which is wrong in case of registry)

@achauhan-scc achauhan-scc requested a review from vizhur February 4, 2025 17:19
@achauhan-scc achauhan-scc merged commit 4c9ea5e into Azure:main Feb 5, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants