[Identity] Fixes to spawn a new instance on macOS #22214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
sadasant,
witemple-msft and
schaabs
as code owners
ghost
added
the
3 tasks
KarishmaGhiya
changed the title
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sadasant
reviewed
Jun 11, 2022
| @@ -244,7 +244,8 @@ export class MsalOpenBrowser extends MsalNode { | |||
| const response = await this.publicApp!.getAuthCodeUrl(authCodeUrlParameters); | |||
|
|
|||
| try { | |||
| await interactiveBrowserMockable.open(response, { wait: true }); | |||
| // A new instance on macOS only which allows it to not hang, does not fix the issue on linux | |||
| await interactiveBrowserMockable.open(response, { wait: true, newInstance: true }); | |||
There was a problem hiding this comment.
Ooh! Interesting 🤔 Thank you!
KarishmaGhiya
added a commit
to KarishmaGhiya/azure-sdk-for-js
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
#21726
Describe the problem that is addressed by this PR
On macOS, the default browser held open the connection, and refused to close the associated sockets unless the window was closed. The workaround with the setting
newInstanceforces a spawn of a new browser instance, not causing the application to hang or the socket to not close.Note : This issue happens in Linux too and is not fixed by the PR. Filed an issue on the
opendependency for linuxAre there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
PR by @mpodwysocki - #22195
Checklists