Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/identity: app never exits when using InteractiveBrowserCredential #21726

Closed
1 of 6 tasks
sinedied opened this issue May 5, 2022 · 5 comments
Closed
1 of 6 tasks
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-author-feedback More information is needed from author to address the issue.
Milestone

Comments

@sinedied
Copy link
Member

sinedied commented May 5, 2022

  • Package Name: @azure/identity
  • Package Version: 2.0.4
  • Operating system: MacOS 12.3.1
  • nodejs
    • version: 16.14.0
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
When authenticating using InteractiveBrowserCredential on MacOS and not using cached credentials, the app never exits. I suspect that the local server used to catch the auth callback is never closed. Using any other auth methods works without having the app stuck at the end.

From some testing with my colleagues, the problem seems to only occur on MacOS, though I did not get the chance to try it myself on Windows and Linux.

To Reproduce
Steps to reproduce the behavior:

  1. Try to authenticate in a Node.js app with
  const browserCredential = new InteractiveBrowserCredential({
    redirectUri: `http://localhost:31337`,
    tenantId: "<your tenant>,
  });
  await browserCredential.getToken("profile")
  console.log("login success");
  1. After login is successful, app never exits.

Expected behavior
The app exists properly after an interactive browser login.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label May 5, 2022
@azure-sdk azure-sdk added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage This issue needs the team to triage. labels May 5, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label May 5, 2022
@sadasant sadasant removed their assignment May 9, 2022
@KarishmaGhiya KarishmaGhiya removed the needs-team-triage This issue needs the team to triage. label May 14, 2022
@KarishmaGhiya KarishmaGhiya added this to the [2022] June milestone May 14, 2022
@KarishmaGhiya
Copy link
Contributor

@sinedied Thank you for reporting. We were able to reproduce this issue on mac, but works fine on windows. We are investigating into this.

@KarishmaGhiya
Copy link
Contributor

KarishmaGhiya commented Jun 10, 2022

@sinedied We did some investigation on our end and found that this issue exists on both Mac and linux OS. We do have a workaround for Mac OS but this workaround still doesn't work for linux. We have filed an issue on the open dependency - sindresorhus/open#287

For now we will release the bug fix 2.0.5 so that we can unblock your issue. We will let you know when we release.
cc: @mpodwysocki

@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@KarishmaGhiya
Copy link
Contributor

@sinedied We have released the @azure/identity 2.0.5 which solves the issue on Mac OS. Please let us know if that works for you and if you have any questions.

@KarishmaGhiya KarishmaGhiya added the needs-author-feedback More information is needed from author to address the issue. label Jun 13, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Jul 5, 2022
@sinedied
Copy link
Member Author

sinedied commented Jul 6, 2022

Sorry for the lag @KarishmaGhiya, I just tested 2.0.5 and it perfectly fixes the issue, thanks! 👍

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Jul 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-author-feedback More information is needed from author to address the issue.
Projects
None yet
Development

No branches or pull requests

6 participants