Sync eng/common directory with azure-sdk-tools for PR 10913 #45739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path.Combine will allow for fully qualified paths to override the combination. For example `Path.Combine("a","b","c:\test")` will resolve to `c:\test'. We have depended on such behavior in a few places like https://github.com/Azure/azure-sdk-for-python/blob/d66b5160f2fb9a3ca03e833a65b1c429993b2bc2/eng/pipelines/templates/steps/smoke-test-steps.yml#L99 so I'm reverting back to Path.Combine.
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common workflow scripts with updates from the azure-sdk-tools repository, ensuring consistent path handling.
- Replaces string interpolation for constructing service directory paths with
Path.Combinefor better cross-platform compatibility.
Comments suppressed due to low confidence (1)
eng/common/TestResources/New-TestResources.ps1:166
- [nitpick] Consider using PowerShell's native Join-Path cmdlet for path concatenation (e.g.,
Join-Path -Path $repositoryRoot -ChildPath "sdk/$ServiceDirectory") to improve readability and consistency with PowerShell conventions.
$root = [System.IO.Path]::Combine($repositoryRoot, "sdk", $ServiceDirectory) | Resolve-Path
weshaggard
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10913 See eng/common workflow