-
Notifications
You must be signed in to change notification settings - Fork 2.1k
GA azure-compute-batch package #44775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
cf554e5
to
d393bef
Compare
e6e58b7
to
8ca1653
Compare
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request prepares the Azure Batch Java SDK for GA status by updating naming conventions, data types (e.g., converting timeouts to Duration), and method signatures in order to enhance consistency and clarity across the API. Key changes include renaming multiple models and their methods (e.g., BatchCertificateDeleteOptions, BatchAllTasksCompleteMode, etc.), updates to handle binary data for certificates, and adjustments in task submission interfaces and error handling.
Reviewed Changes
Copilot reviewed 178 out of 178 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
BatchCertificateDeleteOptions.java | Renamed class and updated timeout type from Integer to Duration using Long internally. |
BatchCertificateDeleteError.java | Renamed class and updated documentation accordingly. |
BatchCertificateCreateOptions.java, BatchCertificateCancelDeletionOptions.java | Similar renaming and timeout updates. |
BatchCertificate.java | Changed certificate data type from String to byte[] and updated JSON serialization. |
BatchApplicationsListOptions.java, BatchApplicationGetOptions.java | Updated timeout getters/setters to use Duration. |
BatchAllTasksCompleteMode.java, BatchAffinityInfo.java | Renamed classes to adhere to naming guidelines. |
AzureFileShareConfiguration.java | Adjusted parameter ordering in constructor; updated assignment sequence and Javadoc parameter order. |
AuthenticationTokenSettings.java, AccessScope.java | Renamed types to reflect new BatchAccessScope usage. |
TaskSubmitter.java, TaskManager.java, SyncTaskSubmitter.java, AsyncTaskSubmitter.java | Updated task submission result types and parameter types to use the new naming convention for task creation. |
pom.xml, CHANGELOG.md, version_client.txt | Updated version information and documented comprehensive breaking and naming changes. |
@@ -210,8 +196,8 @@ public DeleteBatchCertificateError getDeleteCertificateError() { | |||
* @return the data value. | |||
*/ | |||
@Generated | |||
public String getData() { | |||
return this.data; | |||
public byte[] getData() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider performing a defensive copy of the input byte array in the constructor to ensure immutability, similar to the cloning performed in the getter.
Copilot uses AI. Check for mistakes.
* @param relativeMountPath the relativeMountPath value to set. | ||
*/ | ||
@Generated | ||
public AzureFileShareConfiguration(String accountName, String azureFileUrl, String accountKey, | ||
public AzureFileShareConfiguration(String accountName, String accountKey, String azureFileUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the Javadoc parameter list to reflect the new signature order (accountName, accountKey, azureFileUrl, relativeMountPath) to avoid confusion for API consumers.
Copilot uses AI. Check for mistakes.
sdk/batch/azure-compute-batch/src/test/java/com/azure/compute/batch/JobScheduleTests.java
Outdated
Show resolved
Hide resolved
...-batch/src/main/java/com/azure/compute/batch/implementation/lro/JobScheduleDeletePoller.java
Outdated
Show resolved
Hide resolved
...-batch/src/main/java/com/azure/compute/batch/implementation/lro/JobScheduleDeletePoller.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchClient.java
Show resolved
Hide resolved
nit, please use code snippet to write samples in readme.md Here, we can see some samples in readme.md is no longer valid azure-sdk-for-java/sdk/batch/azure-compute-batch/README.md Lines 48 to 56 in 933609d
but there is no BatchServiceClientBuilder or BatchServiceClient .
|
933609d
to
aa8e2fd
Compare
773d443
to
71b26c3
Compare
6d79254
to
11c1aac
Compare
Description
Port the Azure Batch Java Track 2 SDK to GA (General Availability) status
Includes a minor update from our latest TypeSpec to fix naming for properties with adjacent capital cases
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines