Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync eng/common directory with azure-sdk-tools for PR 8294 #40244

Merged
merged 2 commits into from
May 22, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8294 #40244

merged 2 commits into from
May 22, 2024

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8294 See eng/common workflow

@azure-sdk azure-sdk requested a review from scbedd May 17, 2024 20:45
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 17, 2024
scbedd
scbedd approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very minor set of changes being deployed (at least CI wise). I very much doubt the new version is responsible for the test failures.

mitigated on re-run.

@scbedd scbedd merged commit ba810b4 into main May 22, 2024
35 checks passed
@scbedd scbedd deleted the sync-eng/common-pin-upstreamed-proxy-version-8294 branch May 22, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

Assignees

@scbedd scbedd

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azure-sdk @scbedd