Adds injectionRate to FaultInjectionServerErrorResult #40213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
...azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorResultInternal.java
Outdated
Show resolved
Hide resolved
.../java/com/azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorRule.java
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
May 16, 2024
NaluTripician
changed the title
kushagraThapar
approved these changes
May 16, 2024
There was a problem hiding this comment.
Overall looks great @NaluTripician , thank you.
Please add some more testing cases.
...test/src/main/java/com/azure/cosmos/test/faultinjection/FaultInjectionServerErrorResult.java
Outdated
Show resolved
Hide resolved
.../java/com/azure/cosmos/test/implementation/faultinjection/FaultInjectionServerErrorRule.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
May 17, 2024
...rc/test/java/com/azure/cosmos/faultinjection/FaultInjectionServerErrorRuleOnDirectTests.java
Show resolved
Hide resolved
xinlian12
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Application Percentage for ServerErrorRules. This allows users to specify how frequently server error rules are applied. For instance, by setting this value to
.5that rule will be applied 50% of the time. This value is 1, or 100%, by default.Mirror
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines