Add samples for AppConfig Pageable GetLabels with comparisons of what we'd expect the user experience to be. #6338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we'd expect the user experience to be.
ahsonkhan
requested review from
LarryOsterman,
antkmsft,
gearama and
RickWinter
as code owners
|
API change check API changes are not detected in this pull request. |
antkmsft
approved these changes
Jan 14, 2025
LarryOsterman
pushed a commit
to LarryOsterman/azure-sdk-for-cpp
that referenced
this pull request
Jan 14, 2025
… we'd expect the user experience to be. (Azure#6338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6292
The expected user experience is under
#if 0for now since it won't compile.The goal here is to leverage the hero scenario samples for AppConfig to concretely highlight and track the gap between what is generated today vs what we want the end user experience and API design to be.
These particular endpoints highlight newer emitter issues around pageable correctness for url construction from nextpagetokens, and the general pageable pattern:
https://github.com/Azure/autorest.cpp/issues/466
https://github.com/Azure/autorest.cpp/issues/427
Additionally, it requires follow-up on client.tsp modification (assuming TCGC and the emitter support the
@alternateTypedecorator) and investigating a missing response header:#6335
#6337