Skip to content

Return all status changes in the change file function #35379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

Return all status changes in the change file function #35379

merged 3 commits into from
Jun 20, 2025
+2 −1

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Jun 19, 2025 •
edited
Loading

SDK Validation is supposed to run with any kind of changes, such as added, copied, modified, deleted, renamed, and type changed files.

The second commit is for test purposes and will be reverted.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 19, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 19, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@raych1 raych1 self-assigned this Jun 19, 2025
@github-actions GitHub Actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Addons

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 19, 2025
mikeharder
mikeharder reviewed Jun 19, 2025
View reviewed changes
@rkmanda
Copy link
Member

rkmanda commented Jun 20, 2025

dont have much context for the change.. but assuming its related to SDK tooling, I am approving it

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 20, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 20, 2025
@raych1 raych1 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 20, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed resource-manager ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jun 20, 2025
@raych1 raych1 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 20, 2025
@raych1 raych1 moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🔨🏗️💻🚧 Jun 20, 2025
@raych1 raych1 merged commit c78dabe into main Jun 20, 2025
72 of 74 checks passed
@raych1 raych1 deleted the user/raych1/support-deletion-files branch June 20, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@raych1 raych1

Labels
None yet
Projects
Azure SDK EngSys 🔨🏗️💻🚧
Status: 🔬 Dev in PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raych1 @rkmanda @mikeharder @AzureRestAPISpecReview