Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and version query parameters #24929

Open
wants to merge 2 commits into
base: generation
Choose a base branch
from

Conversation

mentat9
Copy link
Member

@mentat9 mentat9 commented May 15, 2024

Description

Fix default formatting for output objects
Remove leftover auto-generated InputObject
Implement -Version and -ListVersion parameters on Get-AzPolicy[Set]Definition Add tests for -Version and -ListVersion
[re]recorded all tests

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

 - Fix default formatting for output objects
 - Remove leftover auto-generated InputObject parameters
 - Remove Helpers.psm1, which was replaced by Helpers.ps1
 - Remove leftover repro test file
 - Rerecord all tests
 - Add info to error message in test harness
…finition

Add tests for -Version and -ListVersion
[re]recorded all tests
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@NoriZC
Copy link
Contributor

NoriZC commented May 16, 2024

This PR is using exactly same name as #24937.
@mentat9 Could you please merge them and only keep one of them open?

@NoriZC NoriZC assigned NoriZC and VeryEarly and unassigned NoriZC May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants