Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alecb generation 2024 01 16 preview #24925

Conversation

alec-baird
Copy link

@alec-baird alec-baird commented May 14, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

hiaga and others added 30 commits April 19, 2024 09:14
…24557)

* Added support for vaulted blobs restore and Update-backupInstance.

* added update BI test case
added ILR test case
added deep validate
added examples

* re-recorded failed tests

* re-recorded failed test
…acks cache and tab completers. (Azure#24656)

* Update Stacks API parser logic

* Update Functions Stack definitions

* Update the logic to populate tab completers only when the Az.Functions cmdlets are invoked

* Update test
…ctionBackupVault, New-AzDataProtectionBackupVault and Update-AzDataProtectionBackupVault cmdlets (Azure#24654)

* cmk ps changes added

CmkEncryption tests added

CmkEncryption added to only UpdateExpanded variant

Updated help text for Update-AzDataProtectionBackupVault cmdlet

* output type and examples update

* Updated API version to 04-01
Added MUA changes for update-vault, stop-protection, suspend-backup, restore commands
re-recorded failed tests

* api version upgrade

* New-AzDataProtectionBackupVault example fix

* fixed CI issues

---------

Co-authored-by: Kartik Mahajan (from Dev Box) <[email protected]>
Co-authored-by: Himanshu Agarwal <[email protected]>
* Upgrade Fleet managed Identity design Add example and test

* Fix update description
* R2D tesing

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Docs update

* Updates

* updates

* Revert "updates"

* Revert "Updates22"

This reverts commit d247880.

* Revert "Docs update2"

This reverts commit 66fa1e4.

* fixing the test failure

* updates

* Revert "updates"

This reverts commit 3f1bcd8.

* Final updatees

* Docs update

* Updates with test

* updates

* Suppressing the breaking change exceptions

* Breaking changes csv update

* Deleted the tring[] file
* create new module: chaos

* update

* Update

* create new module Az.Chaos

* create ExampleIssues.csv
* Create new module: EventGrid

* update

* update

* update

* update

* update breaking change readme directive

* added alias MaxDeliveryAttempt in New-AzEventGridPartnerTopicEventSubscription

* update

* update

* create BreakingChangeIssues.csv
* init add powershell cmdlet

* add customization for filedetails

* correct readme to include file workspace create

* add custom cmdlet for creating and uploading the file

* chunking logic for larger files

* add error for custom cmdlet when file too big

* combined cmdlets

* edit custom file upload command to not use default subscriptionid

* no default value for subid in custom file upload

* separate subscription and no subscription commands

* remove comments from combined cmd for file

* fix cmd

* custom no subscription file upload commands

* autogen docs for no sub file upload

* hide individual file commands

* add back workspace commands

* add name as alias for fileworkspacename fileworkspacesnosubscription

* remove update files and add alias for nosubscription file commands

* tests for get service

* tests for problem classification

* try adding erroractionpreference = stop

* tests for new file workspace

* tests for get file workspace

* more tests

* add tests for new file and upload, removefile name as a parameter

* remove new files no subscription

* tests for get file

* erroraction stop

* remove unnecessary comments and print statements

* docs for get support service

* problem classification docs

* add titles

* documentation for file workspace commands

* documentation for file/file workspace cmdlets

* documentation for checkNameAvailability

* added tests and documentation for operations, support ticket, communication and chat transcript cmdlets

* added examples for operations, support ticket, communication and chat transcript cmdlets

* resolve merge conflicts

* resolved PR comments

* get conflict file changes from grhuang/azsupport-autorest

* resolved merge conflict

* removed update communication sub and no sub scenarios

* Revert "removed update communication sub and no sub scenarios"

This reverts commit ccbfdee.

* removed update communication sub and no sub scenarios , updated readme

* make communiation and support ticket properties required in readme, edit get operation file name, edit calling internal cmdlets for file upload

* fix documentation

* fix top query

* add custom error handler

* consolidate list and get communicationsnosubscription and chattranscriptsnosubscription

* init changes to allow no subscription recording tests-need to use csp partner account in tenant 2e6a0c9f-986d-480e-ad4b-bdfddc047aba

* changes to not create new resources in playback

* remove custom error handler csharp

* init add changes to split subscription and no subscription tests

* update skip

* Update recordings

* update recordings

* add more examples to new-azsupportticket documentation

* update documentation and readme

* add directive back in

* make advanced diagnostic consent required

* Add custom error handling for New- and Update- cmdlets to print full details of error (Azure#9)

* Add custom error handler

* Add default filter to retrieve tickets from the past week for Get-AzSupportTickets and Get-AzSupportTicketsNoSubscription (Azure#10)

* add custom filtering for list support ticket if no filter is applied

* make transformations in swagger in readme to make enrollment id not readonly and show isTempTicket (Azure#11)

* Add argument completer (Azure#12)

* add argument completers

* add quotes to argument completers

* remove repeated time zone

* Regenerate powershell module with GA swagger (Azure#13)

* Rerecord tests using GA version (Azure#14)

* add tests for file size (will add recordings once Ga swagger available)

* Regenerate powershell module with GA swagger

* Rerecord tests with GA version

* Fix documentation

* fix url for file upload

---------

Co-authored-by: Grace Huang (from Dev Box) <[email protected]>
Co-authored-by: grhuangmsft <[email protected]>
Co-authored-by: Shreya Kumar <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
…zure#24221)

* Move Policy CRUD cmdlets to autorest generation: fixes (Azure#23518)

* Set all tests to -LiveOnly
Add back some test infrastructure fixes that were lost
Improve parameter handling for Remove-AzPolicySetDefinition

* Move to supported way of sharing Helpers.psm1 file

* Switch to recommended approach for shared functions

* Update to autorest 4.x (Azure#24319)

Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Update Policy CRUD cmdlets (Azure#24361)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix calculation for $testFilesFolder on macOS/linux (Azure#24408)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-* (Azure#24507)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe (Azure#24540)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Apply changes to support -Playback mode (Azure#24555)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* move creation of resource group to utils.ps1

* Test tweaks (Azure#24566)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* fix test cases

* Correct location handling, fix tests and consistency (Azure#24573)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* Updates for consistency and to fix tests
Make changes to ensure consistent and valid handling of $location
Rerecord tests

* Fix bad merge
Rerecord two test files

* Re-record tests

* remove unnecessary script

* change cached location with a more unique name

* update execution of util script

* fix positional parameters generated when only default parameter set

* fix erroraction for Get-AzPolicyDefinition

* Apply feedback (Azure#24757)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* Updates for consistency and to fix tests
Make changes to ensure consistent and valid handling of $location
Rerecord tests

* Fix bad merge
Rerecord two test files

* Re-record tests

* Implement feedback:
 - Add ResourceId to Get-AzPolicy[Set]Definition
 - Change -BuiltIn to -Builtin
 - Add -InputObject parameter to Update-* cmdlets
 - Control ErrorAction behavior for Get-AzPolicy[Set]Definition
Deprecate the -BackwardCompatible switch

* sync static analysis exceptions

* remove redundant

* added file accidentally removed

---------

Co-authored-by: Yabo Hu <[email protected]>
* Change parsing logic in ATC custom cmdlet

* Add if check

* add if check

* Minor change

* Add UT
* feature storage action 20240131

* Storage Action feature test cases and examples

* Storage Action test added

* Added swagger fix

* Update commit id from swagger main

* Update commit

* Update example

* Update src/StorageAction/StorageAction.Autorest/docs/New-AzStorageActionTask.md

* Update src/StorageAction/StorageAction.Autorest/docs/New-AzStorageActionTask.md

* Update example

---------

Co-authored-by: Yan Xu <[email protected]>
@alec-baird
Copy link
Author

@NoriZC NoriZC self-assigned this May 16, 2024
@NoriZC
Copy link
Contributor

NoriZC commented May 16, 2024

There seems to be a pipeline build issue that is unrelated to this PR? https://dev.azure.com/azclitools/public/_build/results?buildId=158503&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=8aac088c-bc37-5d41-cf85-af8ebfb740e5&l=1502

Yes I am confirming with my teammates about the issue. Meanwhile you can try merging generation branch and see whether the issue resolved.

@NoriZC
Copy link
Contributor

NoriZC commented May 20, 2024

Hi @alec-baird Yes you need to merge the latest generation branch to fix the issue.

@alec-baird alec-baird requested a review from isra-fel as a code owner May 20, 2024 18:47
@alec-baird
Copy link
Author

Hi @alec-baird Yes you need you merge the latest generation branch to fix the issue.

Done.

@alec-baird
Copy link
Author

@NoriZC , @isra-fel , All of my tests passed locally but there seem to be a few failing your CI, is there a bug in CI still?

@alec-baird
Copy link
Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 24925 in repo Azure/azure-powershell

@NoriZC
Copy link
Contributor

NoriZC commented May 30, 2024

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC
NoriZC previously approved these changes May 30, 2024
@NoriZC NoriZC dismissed their stale review May 30, 2024 06:01

The pr is mixed up two things, will take them apart and raise another prs for you.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Copy link
Contributor

1 file(s) have code issues.

File Issues
.github/policies/resourceManagement.yml Exception during deserialization. Failed to create an instance of type 'GitOps.PullRequestIssueManagement.Core.Primitives.Data.Frequencies.SearchFrequency'.. Cannot dynamically create an instance of type 'GitOps.PullRequestIssueManagement.Core.Primitives.Data.Frequencies.SearchFrequency'. Reason: Cannot create an abstract class.

Total execution time: 0.07 seconds

@NoriZC
Copy link
Contributor

NoriZC commented May 30, 2024

The new pr: #25035

@NoriZC NoriZC closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet