Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access rule servicetag #24905

Conversation

bhupeshbhatt1985
Copy link

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

azure-powershell-bot and others added 30 commits March 17, 2024 14:31
…zation (#24404)

* Added breaking change warning message for parameter EnableRbacAuthorization of New-AzKeyVault

* add wrong deletion back

* add wrong deletion back
* Fix the help files

* Fix the help files

* Update the description of parameters
* Update KeyVault.format.ps1xml

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: Vincent Dai <[email protected]>
…#24105)

* Enabled globally disabling instance discovery before token acquisition

Fix #22535

* Address review comments

---------

Co-authored-by: Beisi Zhou <[email protected]>
* added values for Hashset

* Added parameters in example
…mage (#24437)

* breaking change warnings

* getazvmss brk msg

* Update ChangeLog.md
* Move DataMigration to main

* Update ChangeLog.md

---------

Co-authored-by: Vincent Dai <[email protected]>
* Move ApplicationInsights to main

* Update ChangeLog.md

* Update Get-AzApplicationInsightsWorkbookRevision.md

* Update Get-AzApplicationInsightsWorkbookRevision.md

---------

Co-authored-by: Vincent Dai <[email protected]>
* Move EventHub to main

* Update ChangeLog.md

* Update Approve-AzEventHubPrivateEndpointConnection.Tests.ps1

* Update New-AzEventHubGeoDRConfiguration.Tests.ps1

* Update Set-AzEventHubGeoDRConfigurationBreakPair.Tests.ps1

* Update Set-AzEventHubGeoDRConfigurationFailOver.Tests.ps1

* Update Approve-AzEventHubPrivateEndpointConnection.Tests.ps1

* Update Set-AzEventHubGeoDRConfigurationBreakPair.Tests.ps1

---------

Co-authored-by: Vincent Dai <[email protected]>
* Move Compute to main

* Update ChangeLog.md

* Update ExampleIssues.csv

---------

Co-authored-by: Yabo Hu <[email protected]>
* Fix for a permissions null check in TOPSRoledefinition

* Updating change log

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: veseshad92 <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
* Delete src/DevSpaces directory

* Update azure-powershell-modules.md

* Update AzPreview.psd1
* Move ServiceBus to main

* Update ChangeLog.md

* Update Approve-AzServiceBusPrivateEndpointConnection.Tests.ps1

* Update New-AzServiceBusGeoDRConfiguration.Tests.ps1

* Update Set-AzServiceBusGeoDRConfigurationBreakPair.Tests.ps1

* Update Set-AzServiceBusGeoDRConfigurationFailOver.Tests.ps1

* Update Start-AzServiceBusMigration.Tests.ps1

---------

Co-authored-by: Vincent Dai <[email protected]>
phrazfipho and others added 16 commits May 10, 2024 16:39
…end address (#24872)

* [Networking] - Add Connection Draining support for load balancer backend address

* generate record json
…tAvailable (#24865)

* Fixed a null reference issue during the process of Get-AzContext -ListAvailable [#24854]

* Update src/Accounts/Accounts/Context/GetAzureRMContext.cs
* Minor changes for interactive subscription selection

* remove extra line
* Move CustomLocation to main

* Upgraded managed identity parameters for CustomLocation

* Updated example issue exception for managed identity

* Updated example issue exception of Get-AzConnectedKubernetes and Get-AzKubernetesExtension

---------

Co-authored-by: JoyerJin <[email protected]>
…int (#24807)

* switch skr policy from github to maa endpoint

* add change log

* refine code
…on when user explicitly sets SecurityType to Standard (#24773)

* generated code

* dev, test, and changelog

* simplifying to just feature ask

* fixed null errors

* cleanup

* remove brk msg
* Move KubernetesConfiguration to main

* update changelog

---------

Co-authored-by: Jinpei Li <[email protected]>
* remove breaking change messages

* update changelog

* update the changelog message
Copy link

azure-client-tools-bot-prd bot commented May 13, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
🔄Az.Aks
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Functions
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.KubernetersConfiguration
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
❌Az.Network
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
CS1061 D:\a_work\1\s\src\Network\Network.Test\ScenarioTests\NetworkTestRunner.cs(84,75) 'TestEnvironment' does not contain a definition for 'GetAccessToken' and no accessible extension method 'GetAccessToken' accepting a first argument of type 'TestEnvironment' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Network\Network.Test\Network.Test.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.PostgreSql
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Purview
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Test
🔄PowerShell Core - Windows

Copy link
Contributor

Thank you for your contribution bhupeshbhatt1985! We will review the pull request and get back to you soon.

ashutmi and others added 9 commits May 13, 2024 20:28
…#24898)

* Adding support for Inbound Security Rule creation for NVA

* Adding Tests fixing cmdlet import issue

* Removing changes made for local testing failures

* Removing changes from the file CommandMappings.json

* Adding online versions for the help file

* Adding changes to fix static analysis errors for command naming

* Adding Parameter checks

* Adding mandatory check for Name Parameter & removing * for protocol

* Adding missed mappings
… and Trusted Launch (#24869)

* development

* finish feature dev

* changelog and md file

* add new test

* update working in changelog

* add one more scenario to test

* assert line

* collap function to one line code

* add closing brace back to fix the error in code structure

* update documentation

* better wording

* Update New-AzGalleryImageDefinition.md

* Update New-AzGalleryImageDefinition.md

---------

Co-authored-by: YanaXu <[email protected]>
* Added Support for Network Profile in Virtual Appliance

* Added online version in md files

* Minor fixes in md files and splitting the cmdlets in separate files

* Added network profile in test

* Fixed CI Signature Issues

* Minor fix in example

---------

Co-authored-by: Yan Xu <[email protected]>
* Fix static analysis help check issue

* Fix static analysis help check issue

* Fix static analysis issue
* Add suppport for TestFx to record with user account

* Mark using existing service principal also as not recommended
* generate migration guide for Az 12.0.0

* Update documentation/migration-guides/Az.12.0.0.0-migration-guide.md

Co-authored-by: Yeming Liu <[email protected]>

* update Az.Compute part format

* Update documentation/migration-guides/Az.12.0.0.0-migration-guide.md

Co-authored-by: yifanz7 <[email protected]>

* update according to comments

---------

Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: yifanz7 <[email protected]>
@bhupeshbhatt1985 bhupeshbhatt1985 closed this by deleting the head repository May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet