-
Notifications
You must be signed in to change notification settings - Fork 33
Adding safety timeouts for package manager operations and increasing the test limit for remediations #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could this PR be split into two? The changes in ExecuteCommand seem to be completely unrelated to the core ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please split this PR into separate PRs:
- timeout changes
- style changes
Will do. |
Done. Removed all changes from CommandUtils.c to issue a separate PR for those. They were related because as described in the original PR description, the timeout added in PackageUtils.c depends on this reworked code here. There are 2 lines with TAB characters and various other minor code formatting issues in CommandUtils.c which can create a bad precedent for this code (curious how the TABs escaped with the pre-commit rule in place, when I run pre-commit locally they are caught). Will open a separate PR for these cosmetic issues as you asked. |
6bf3feb
to
f836f4b
Compare
6feb1ee
Description
Adding safety timeouts for package manager operations (30 minutes, which can act during RC/DC where we do not have overall timeouts like Azure Policy) and increasing the test limit for remediations (5 minutes per rule, this being the actual fix to the random CI failures, problem being that we just had too strict limits there, which we expected and now thanks to such findings we are adjusting).
Checklist
dev
branch prior to this PR submission.dev
branch.