Skip to content

Unblock execution of all module tests #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 2, 2025

Conversation

robertwoj-microsoft
Copy link
Contributor

@robertwoj-microsoft robertwoj-microsoft commented Mar 28, 2025

Description

Drop src/tests/e2e-test-recipes directory and condition that allows to run only selected subset of module tests. This is to ease addition of new tests and to avoid missing potential regressions in other, less important modules.

There are some module tests written, but we don't build relevant modules yet, so for now module tests for which we don't have a module built, we skip execution.

In the process of enablement of all module tests, I encountered a few issues in compliance module tests as they were not run before and fixed accordingly.

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

Copy link

github-actions bot commented Mar 28, 2025

Test Results

 44 files  ±0   44 suites  ±0   36m 47s ⏱️ -41s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
176 runs  ±0  154 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 1c84476. ± Comparison against base commit d050c32.

♻️ This comment has been updated with latest results.

AhmedBM
AhmedBM previously approved these changes Mar 28, 2025
@robertwoj-microsoft robertwoj-microsoft force-pushed the robertwoj/unblock_all_module_tests branch from d4a17ee to b195981 Compare March 31, 2025 07:54
@robertwoj-microsoft robertwoj-microsoft marked this pull request as ready for review March 31, 2025 08:24
@robertwoj-microsoft robertwoj-microsoft requested a review from a team as a code owner March 31, 2025 08:24
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit be8bddb into dev Apr 2, 2025
109 checks passed
@MariusNi MariusNi deleted the robertwoj/unblock_all_module_tests branch April 2, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants