Skip to content

EnsureFilePermissions compliance check module tests #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

EnsureFilePermissions compliance check module tests #913

merged 3 commits into from
Apr 14, 2025

Conversation

robertwoj-microsoft
Copy link
Contributor

@robertwoj-microsoft robertwoj-microsoft commented Mar 17, 2025 •
edited
Loading

Description

Add a bunch of module tests and fix some issues popped up during testing:

  • Do not allow passing both permissions and mask parameters to ensureFilePermissions
  • Fix mask handling
  • Do not report error but return failure if a user/group does not exist

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

Test Results

 44 files  ±0   44 suites  ±0   28m 47s ⏱️ - 1m 28s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
176 runs  ±0  154 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 3559504. ± Comparison against base commit 2e95116.

♻️ This comment has been updated with latest results.

@wupeka wupeka marked this pull request as ready for review March 17, 2025 14:46
@wupeka wupeka requested a review from a team as a code owner March 17, 2025 14:46
@wupeka wupeka marked this pull request as draft March 17, 2025 14:47
MariusNi
MariusNi reviewed Mar 18, 2025
View reviewed changes
@robertwoj-microsoft robertwoj-microsoft mentioned this pull request Mar 19, 2025
Merged
5 tasks
MariusNi
MariusNi previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@robertwoj-microsoft robertwoj-microsoft force-pushed the robertwoj/fix_RemoveUserAccounts branch from a1dfc13 to 9649494 Compare March 26, 2025 14:39
@robertwoj-microsoft robertwoj-microsoft force-pushed the robertwoj/compliance_moduletests_ensureFilePermissions branch from dd84856 to 459ab6e Compare April 9, 2025 10:36
@robertwoj-microsoft robertwoj-microsoft changed the base branch from robertwoj/fix_RemoveUserAccounts to dev April 9, 2025 10:45
@robertwoj-microsoft robertwoj-microsoft dismissed MariusNi’s stale review April 9, 2025 10:45

The base branch was changed.

@robertwoj-microsoft robertwoj-microsoft marked this pull request as ready for review April 9, 2025 10:46
AhmedBM
AhmedBM reviewed Apr 11, 2025
View reviewed changes
@robertwoj-microsoft
EnsureFilePermissions compliance check module tests and logging
8e7ce81 
- Add module tests for EnsureFilePermissions procedure
- Add logging
- Adjust error handling
- Adjust error messages
- Adjust logstream messages
@robertwoj-microsoft
Address code review issues #1
b7ef519
@robertwoj-microsoft robertwoj-microsoft force-pushed the robertwoj/compliance_moduletests_ensureFilePermissions branch from 459ab6e to b7ef519 Compare April 14, 2025 08:51
MariusNi
MariusNi approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit 61201ad into dev Apr 14, 2025
109 checks passed
@MariusNi MariusNi deleted the robertwoj/compliance_moduletests_ensureFilePermissions branch April 14, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wupeka wupeka wupeka approved these changes

@AhmedBM AhmedBM AhmedBM approved these changes

@MariusNi MariusNi MariusNi approved these changes

@danielszot danielszot Awaiting requested review from danielszot

@jepio jepio Awaiting requested review from jepio

@kkanas kkanas Awaiting requested review from kkanas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertwoj-microsoft @AhmedBM @wupeka @MariusNi