Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address flaky TestAppOfflineDebounceTime test #10128

Merged
merged 2 commits into from
May 30, 2024
Merged

Address flaky TestAppOfflineDebounceTime test #10128

merged 2 commits into from
May 30, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented May 8, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Noticed this test failing occasionally. This PR is an attempt to improve stability (without deadlocking).

@jviau jviau requested a review from a team as a code owner May 8, 2024 17:48
@jviau jviau merged commit 3d401d3 into dev May 30, 2024
10 checks passed
@jviau jviau deleted the jviau/flaky-test branch May 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants