Core Tools OOP Host #3802

aishwaryabh · 2024-08-28T21:04:59Z

Issue describing the changes in this PR

resolves #3744

This PR creates the feature branch feature/oop-host, which has the OOP host build. This PR also includes checks for the user passing in the --runtime param specifying the host and infers the host if that is not specified. I've also added tests which checks that we try to execute the correct func.exe (even though those tests technically fail since there is no inproc-6 or inproc-8 folder). We also only run on .NET 8 TFM and remove multi-targeting in the feature branch.

For when the user specifies the --runtime parameter, these are the following scenarios we support today where the first row is the options the user may put in and the first column are the potential apps a user may have:

	inproc6	inproc8	default
.NET Isolated app			x
.NET 6 in-proc app	x
.NET 8 in-proc app		x
non .NET app			x

Anything that does not have an X within it throws an error to the user with a helpful message on why the passed in host runtime is not valid.

For inference the path will be:

	Sequence	Tool version
.NET Isolated app	default	default
.NET 6 in-proc app	default -> inproc6	inproc6
.NET 8 in-proc app	default -> inproc8	inproc8
non .NET app	default	default

This is how the logic looks like today for the inference scenario:

If app is in-proc app
- If FUNCTIONS_INPROC_NET8_ENABLED is set
  - Run inproc8 host
- Else
  - Run inproc6 host
else
- Run OOP host

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes do not need to be backported to a previous version
- Otherwise: Backport tracked by issue/PR #issue_or_pr
I have added all required tests (Unit tests, E2E tests)

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

…tools into aibhandari/core-tools-oop

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

src/Azure.Functions.Cli/Azure.Functions.Cli.csproj

…tools into aibhandari/core-tools-oop

azure-pipelines.yml

build.ps1

eng/ci/public-build.yml

pipelineUtilities.psm1

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

src/Azure.Functions.Cli/Azure.Functions.Cli.csproj

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

kshyju · 2024-09-19T15:16:32Z

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

            {
-                FileName = inProc8FuncExecutablePath,
+                FileName = funcExecutablePath,


Where do we use the --no-build argument?

We use it in line 626?

test/Azure.Functions.Cli.Tests/Azure.Functions.Cli.Tests.csproj

fabiocav · 2024-09-19T18:43:59Z

The table shared above doesn't seem to capture the expected supported scenarios.

Shouldn't this reflect what is supported when --runtime is explicitly set?

	inproc6	inproc8	default
.NET Isolated app			x
.NET 6 in-proc app	x
.NET 8 in-proc app		x
non .NET app			x

For inference, the path would always be:

	Sequence	Tool version
.NET Isolated app	default	default
.NET 6 in-proc app	default -> inproc6	inproc6
.NET 6 in-proc app	default -> inproc8	inproc8
non .NET app	default	default

EDIT: This information was applied to the PR description

…ctions-core-tools into aibhandari/core-tools-oop

fabiocav · 2024-09-20T00:17:27Z

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

@@ -418,15 +421,47 @@ private async Task<JObject> GetLocalSettingsJsonAsJObjectAsync()
        public override async Task RunAsync()
        {
            await PreRunConditions();
+            var isVerbose = VerboseLogging.HasValue && VerboseLogging.Value;


Can we move this logic that is specific to .NET to a different method and out of RunAsync? That will help declutter this method and make the code easier to navigate.

This will also enable you to reduce the variables as you'll be able to drive the logic without needing to have an additional flag for OOP.

Moved this logic into: ShouldExitAfterDeterminingHostRuntime to clean up RunAsync

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

fabiocav

There are a few changes/improvements I'm tracking, but let's get this merged into the feature branch and collaborate there.

* this doesn't work * this finally works now * default should be oop host * added edge cases * fixing formatting * using determineTargetFramework * saving tests * adding copy step for OOP * fixing the webhost reference * removing test * setting host version in ps script * update to validate worker versions script * update versions for worker packages * adding ToString * validating worker version * validate worker versions * updating csproj to compile * addressing pr feedback * updating build steps * adding build step * fixing build step * trying to get this working * reverrting target runtimes * updating tests * adding dotnet info step * adding changes * removing extra test * trying to specify architecture * modifying tests to see if they work * narrowing down to tests that are failing * trying to see if it works with nobuild flag * addressing pr feedback * updating tests with latest logging * addressing comments and marking flaky tests * updating so that we are only using net8 framework * pushing change for branch build * adding single quotes * reverting quotes * adding code mirror fiile * updating build step * updatinng build steps * updating build step * adding step for dotnet publish * set inprochost compilation system to diff value and skip flaky test * updating public build pipeline to trigger * adding extra changes for pipeline * public build yml * updating official build * readd net8 build artifact step * readding space back * addressing initial comments * adding explicit openTelemetry dlls * simplifying logic of startHostAction * addressing PR feedback * start tests * changing some of the tests back * reverting test back to normal * fixing spacing for csproj * addressing PR feedback * adding extra variable * adding logic for edge case scenarios * added edge cases tests * removing extra line in node * addressing comments * moving validate host runtime to its own method * forgot to add return statement

aishwaryabh added 5 commits August 27, 2024 13:45

this doesn't work

704ac4e

this finally works now

3c2d57e

default should be oop host

8e1a8b8

added edge cases

dba7366

fixing formatting

e10e828

kshyju reviewed Sep 4, 2024

View reviewed changes

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs Outdated Show resolved Hide resolved

aishwaryabh added 6 commits September 4, 2024 11:43

using determineTargetFramework

8cace5c

Merge branch 'v4.x' of https://github.com/Azure/azure-functions-core-…

b3edb40

…tools into aibhandari/core-tools-oop

saving tests

e8513a6

adding copy step for OOP

58cec33

fixing the webhost reference

bda722f

removing test

8cb1b78

aishwaryabh marked this pull request as ready for review September 5, 2024 23:57

aishwaryabh requested review from a team as code owners September 5, 2024 23:57

kshyju reviewed Sep 6, 2024

View reviewed changes

aishwaryabh added 10 commits September 6, 2024 11:24

setting host version in ps script

cef04a0

update to validate worker versions script

fa7d681

update versions for worker packages

0a85400

adding ToString

654e34b

validating worker version

ba31c33

validate worker versions

e420bee

updating csproj to compile

9689ef4

addressing pr feedback

f705868

updating build steps

c175762

Merge branch 'v4.x' of https://github.com/Azure/azure-functions-core-…

83c0a23

…tools into aibhandari/core-tools-oop

aishwaryabh changed the base branch from v4.x to feature/oop-host September 9, 2024 20:16

aishwaryabh changed the base branch from feature/oop-host to v4.x September 9, 2024 20:16

aishwaryabh added 2 commits September 9, 2024 14:59

adding build step

d018052

fixing build step

9e65428

aishwaryabh mentioned this pull request Sep 18, 2024

Investigate why tests are being flakey #3828

Open

aishwaryabh added 2 commits September 18, 2024 10:58

addressing initial comments

c9844d1

adding explicit openTelemetry dlls

b13a532

liliankasem reviewed Sep 18, 2024

View reviewed changes

aishwaryabh added 5 commits September 18, 2024 14:25

simplifying logic of startHostAction

697847d

addressing PR feedback

4d9681f

start tests

ba7caec

changing some of the tests back

4821e73

reverting test back to normal

b656fa1

kshyju reviewed Sep 19, 2024

View reviewed changes

aishwaryabh added 3 commits September 19, 2024 09:35

fixing spacing for csproj

7545285

addressing PR feedback

e21065e

adding extra variable

490eaf9

aishwaryabh added 4 commits September 19, 2024 12:47

adding logic for edge case scenarios

456aaa7

added edge cases tests

da89da0

Merge branch 'feature/oop-host' of https://github.com/Azure/azure-fun…

1bbca61

…ctions-core-tools into aibhandari/core-tools-oop

removing extra line in node

2cdbfe8

aishwaryabh mentioned this pull request Sep 20, 2024

Custom host changes for VS Scenario #3831

Merged

5 tasks

fabiocav reviewed Sep 20, 2024

View reviewed changes

aishwaryabh added 3 commits September 20, 2024 09:56

addressing comments

cc01008

moving validate host runtime to its own method

72af8da

forgot to add return statement

8b31c8e

fabiocav approved these changes Sep 24, 2024

View reviewed changes

aishwaryabh merged commit 2d35b1b into feature/oop-host Sep 24, 2024
4 checks passed

aishwaryabh deleted the aibhandari/core-tools-oop branch September 24, 2024 19:05

mattchenderson mentioned this pull request Sep 25, 2024

Core Tools updates to use out-of-process host by default #3744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core Tools OOP Host #3802

Core Tools OOP Host #3802

aishwaryabh commented Aug 28, 2024 •

edited

Loading

kshyju Sep 19, 2024

aishwaryabh Sep 19, 2024

fabiocav commented Sep 19, 2024 •

edited

Loading

fabiocav Sep 20, 2024

fabiocav Sep 20, 2024

aishwaryabh Sep 20, 2024

fabiocav left a comment

Core Tools OOP Host #3802

Core Tools OOP Host #3802

Conversation

aishwaryabh commented Aug 28, 2024 • edited Loading

Issue describing the changes in this PR

Pull request checklist

kshyju Sep 19, 2024

Choose a reason for hiding this comment

aishwaryabh Sep 19, 2024

Choose a reason for hiding this comment

fabiocav commented Sep 19, 2024 • edited Loading

fabiocav Sep 20, 2024

Choose a reason for hiding this comment

fabiocav Sep 20, 2024

Choose a reason for hiding this comment

aishwaryabh Sep 20, 2024

Choose a reason for hiding this comment

fabiocav left a comment

Choose a reason for hiding this comment

aishwaryabh commented Aug 28, 2024 •

edited

Loading

fabiocav commented Sep 19, 2024 •

edited

Loading