-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gozip across different host OS architectures #3650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@khkh-ms / @amamounelsayed Please review/accept this fix - this is a blocker for me on an M2 Mac. Thanks! |
@drew1326 as a temporary workaround, you can manually build the gozip binary & replace it. |
/azp run coretools.public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run coretools.public |
Azure Pipelines successfully started running 1 pipeline(s). |
Thank you, @mxschmitt ! Re-running the build to make sure we're green. |
Thank you, @mxschmitt , for the contribution and the patience! |
Is there a nightly build from where I can grab the correct gozip executable? Current latest 4.06280 seems to be affected by the bug. Edit: Otherwise, is this the gozip that needs to be compiled and replace the wrong one? https://github.com/sanderhahn/gozip |
Before for e.g. macOS or Windows the
gozip
executable did not match the target OS architecture. This PR fixes that:Issue describing the changes in this PR
Fixes #3648
Pull request checklist
cc @arroyc