Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gozip across different host OS architectures #3650

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 24, 2024

Before for e.g. macOS or Windows the gozip executable did not match the target OS architecture. This PR fixes that:

image

Issue describing the changes in this PR

Fixes #3648

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

cc @arroyc

Copy link

@onexbash onexbash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drew1326
Copy link

@khkh-ms / @amamounelsayed Please review/accept this fix - this is a blocker for me on an M2 Mac. Thanks!

@onexbash
Copy link

@drew1326 as a temporary workaround, you can manually build the gozip binary & replace it.

@fabiocav
Copy link
Member

/azp run coretools.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mxschmitt mxschmitt requested a review from a team as a code owner September 18, 2024 08:22
@mxschmitt
Copy link
Member Author

@fabiocav pushed a fix (481986a) which started failing after a0fe7af.

@fabiocav
Copy link
Member

/azp run coretools.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fabiocav
Copy link
Member

Thank you, @mxschmitt ! Re-running the build to make sure we're green.

@fabiocav
Copy link
Member

Thank you, @mxschmitt , for the contribution and the patience!

@fabiocav fabiocav merged commit 37b826f into Azure:v4.x Sep 19, 2024
4 checks passed
@ldibanyez
Copy link

ldibanyez commented Oct 22, 2024

Is there a nightly build from where I can grab the correct gozip executable? Current latest 4.06280 seems to be affected by the bug.

Edit: Otherwise, is this the gozip that needs to be compiled and replace the wrong one? https://github.com/sanderhahn/gozip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gozip: Bad CPU type in executable
7 participants