Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return non-zero exit status if failed to parse the action #3601

Open
wants to merge 1 commit into
base: v4.x
Choose a base branch
from
Open

Return non-zero exit status if failed to parse the action #3601

wants to merge 1 commit into from

Conversation

gukoff
Copy link

@gukoff gukoff commented Feb 20, 2024

Issue describing the changes in this PR

Do not swallow CliArgumentsException. Return non-zero exit code if CLI arguments are incorrect.

Fixes #3277

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@gukoff
Copy link
Author

gukoff commented Feb 20, 2024

It likely needs backporting. What's the right procedure?

@gukoff
Copy link
Author

gukoff commented Mar 11, 2024

ping!

@gukoff
Copy link
Author

gukoff commented May 3, 2024

ping? @khkh-ms @amamounelsayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khkh-ms khkh-ms Awaiting requested review from khkh-ms khkh-ms is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero exit status on error
1 participant
@gukoff