Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[func logs kubernetes] Add --namespace #3488

Conversation

sdahlbac
Copy link
Contributor

Issue describing the changes in this PR

The selector for selecting the pod was incorrect, use the passed in name.
Make it possible to specify in what namespace the function was deployed into.

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju
Copy link
Member

kshyju commented Jul 10, 2024

@sdahlbac Can you add/update tests which handle this change?

@sdahlbac
Copy link
Contributor Author

I guess I could perhaps do so, but the fact that it took 9months!?! to get even a first reply does not make me more inclined to invest the time to do so...

@sdahlbac
Copy link
Contributor Author

@kshyju pardon my French but wtf with this stale bot?

@kshyju
Copy link
Member

kshyju commented Jul 22, 2024

I guess I could perhaps do so, but the fact that it took 9months!?! to get even a first reply does not make me more inclined to invest the time to do so...

Apologies for the delay. Other repositories took priority, and this PR did not receive the attention it deserved. We are currently cleaning up and improving this repository. Moving forward, response times will be much faster. We genuinely appreciate your contribution. Thank you for your patience.

Additionally, the stale bot is an automated tool helping with the cleanup of inactive PRs. It will flag PRs with no activity.

Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants