add azr metrics in heartbeats #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this suffers from some import cycles, so it won't compile. |
ZetaoZhuang
force-pushed
the
add_azr_metrics_in_heartbeat
branch
from
b100cdf
to
4a96e92
Compare
ZetaoZhuang
force-pushed
the
add_azr_metrics_in_heartbeat
branch
from
8980541
to
72ae3ab
Compare
smittal22
reviewed
May 29, 2024
timraymond
reviewed
May 30, 2024
timraymond
previously approved these changes
May 31, 2024
ramiro-gamarra
requested changes
May 31, 2024
ZetaoZhuang
force-pushed
the
add_azr_metrics_in_heartbeat
branch
from
9eb54c3
to
135948b
Compare
ZetaoZhuang
force-pushed
the
add_azr_metrics_in_heartbeat
branch
from
f12c33a
to
f1c5107
Compare
ramiro-gamarra
approved these changes
Jun 4, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
for Direct CNS mode, we want to add IsAZRSupported and HomeAZ as custom metrics in heartbeats, that way we know if a node has azr enabled or not.
Issue Fixed:
Requirements:
Notes: