Skip to content

CosmosDB Fleet Preview #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pjohari-ms
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 20:43
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @pjohari-ms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 21, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for specifying global database account properties on Fleetspace accounts within the CosmosDB preview SDK.

  • Introduces a new FleetspaceAccountPropertiesGlobalDatabaseAccountProperties model.
  • Replaces the old account_resource_identifier and account_location fields on FleetspaceAccountResource with the new global_database_account_properties field.
  • Exports the new model in the package’s __init__.py.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/_models_py3.py Added FleetspaceAccountPropertiesGlobalDatabaseAccountProperties class and updated FleetspaceAccountResource.
src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/init.py Added the new model to the module import list and __all__.
Comments suppressed due to low confidence (1)

src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/_models_py3.py:7955

  • Consider adding unit tests for the new FleetspaceAccountPropertiesGlobalDatabaseAccountProperties model to verify serialization behavior and attribute mapping.
class FleetspaceAccountPropertiesGlobalDatabaseAccountProperties(_serialization.Model):  # pylint: disable=name-too-long

Comment on lines +7956 to +7961
"""Configuration for fleetspace Account in the fleetspace.

:ivar resource_id: The resource identifier of global database account in the Fleetspace
Account.
:vartype resource_id: str
:ivar arm_location: The location of global database account in the Fleetspace Account.
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The class docstring is phrased as 'Configuration for fleetspace Account in the fleetspace.' Consider rewording for clarity and consistent capitalization, e.g., 'Configuration for a global database account in the Fleetspace account.'

Suggested change
"""Configuration for fleetspace Account in the fleetspace.
:ivar resource_id: The resource identifier of global database account in the Fleetspace
Account.
:vartype resource_id: str
:ivar arm_location: The location of global database account in the Fleetspace Account.
"""Configuration for a global database account in the Fleetspace account.
:ivar resource_id: The resource identifier of the global database account in the Fleetspace
account.
:vartype resource_id: str
:ivar arm_location: The location of the global database account in the Fleetspace account.

Copilot uses AI. Check for mistakes.

:ivar resource_id: The resource identifier of global database account in the Fleetspace
Account.
:vartype resource_id: str
:ivar arm_location: The location of global database account in the Fleetspace Account.
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space between 'of' and 'global'. Please remove the double space for consistency.

Suggested change
:ivar arm_location: The location of global database account in the Fleetspace Account.
:ivar arm_location: The location of global database account in the Fleetspace Account.

Copilot uses AI. Check for mistakes.

Copy link

Hi @pjohari-ms

Release Suggestions

Module: cosmosdb-preview

  • Please log updates into to src/cosmosdb-preview/HISTORY.rst
  • Update VERSION to 1.5.1 in src/cosmosdb-preview/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CosmosDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants