-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CLI command description update #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI command description update #8776
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Hi @shivansh257, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure CLI Datadog extension by adding and updating new commands that manage Datadog monitor resources, including operations like show, delete, get/set default keys, list various resources, and refresh password links.
- Adds new command implementations for Datadog monitor operations.
- Updates command group initializations, help files, and version history to reflect the latest CLI extension release.
Reviewed Changes
Copilot reviewed 83 out of 83 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_show.py | Adds the "show" command for retrieving a Datadog monitor resource properties. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_set_default_key.py | Implements the "set-default-key" command to update the default API key. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_refresh_set_password_link.py | Adds a command to refresh the password link for monitor resources. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_list_monitored_resource.py | Provides listing for resources monitored by a specific Datadog monitor. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_list_linked_resource.py | Implements listing of linked Azure resources for a monitor. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_list_host.py | Adds a command to list hosts monitored by a Datadog monitor resource. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_list_api_key.py | Implements listing of API keys associated with a Datadog monitor. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_get_default_key.py | Adds the command to fetch the default API key for a monitor. |
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_delete.py | Adds deletion support for Datadog monitor resources. |
Other files | Update command group definitions, loader functions, README, and history documentation. |
Comments suppressed due to low confidence (1)
src/datadog/azext_datadog/aaz/latest/datadog/monitor/_set_default_key.py:47
- Consider aligning the monitor name argument options with other commands by including the short flag (e.g., '-n'). Consistent option names across commands improve usability.
_args_schema.monitor_name = AAZStrArg(
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
All the parameters using underscore ("_") have been updated with new commands as new codegen tool have the regex condition [a-z0-9]+(-[a-z0-9]+)* properties parameter is removed and nested params are added directly. required = true, there is no change in swagger. These values are added by previous swagger version. Old codegen tool might not have generated this. cmd datadog terms update removed --> there is no change in swagger. These values are added by previous swagger version. Old codegen tool might have generated but is not being regenerated now. Also it is in experimental phase. Will be updated in future version release. |
[Release] Update index.json for extension [ datadog-1.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125331468&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.As part of this update CLI command description is updated.
There is known issue with this CLI version due to which few CLI commands are breaking. We will update the CLI versions in upcoming months.