-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added Support to Input Multiple Managed Identities and Remove Identity Object from Firewall Policy #8751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Support to Input Multiple Managed Identities and Remove Identity Object from Firewall Policy #8751
Conversation
…y Object from Firewall Polcicy
❌Azure CLI Extensions Breaking Change Test
|
Hi @Balashivaram, |
Hi @Balashivaram, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: azure-firewall
Notes
|
@Balashivaram please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@Balashivaram plz kindly fix the ci failures. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
With new changes people can input multiple Managed Identities and also remove Managed Identity by setting identity type to None :
1. az network firewall policy create -g {rg} -n {policy_name} --sku Premium --explicit-proxy enable-explicit-proxy=true http-port=85 enable-pac-file=true pac-file-port=122 pac-file="{sas_url}" --identity {identity1_resourceid} {identity2_resourceid}
2. az network firewall policy update -g {rg} -n {policy_name} --explicit-proxy enable-explicit-proxy=false --identity-type "None"
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.