Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template azd-functions-sharepoint-webhooks #495

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Yvand
Copy link

@Yvand Yvand commented Jan 28, 2025

This PR is to add an azd template for SharePoint webhooks to the gallery.

Your template repository

https://github.com/Yvand/azd-functions-sharepoint-webhooks

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

@hemarina
Copy link
Contributor

@v-xuto Could you test this template?

@Yvand
Copy link
Author

Yvand commented Jan 29, 2025

The workflow fails because "The tag "sharepoint" is not defined in ./src/data/tags.tsx"
Since this template is very much about SharePoint, can it be considered to be added as a tag, or should I delete this tag from my template?

@hemarina
Copy link
Contributor

Thank you for your contribution! Adding SharePoint tag is a great idea. Please add it under tags, e.g. #492.

@Yvand
Copy link
Author

Yvand commented Jan 30, 2025

Just added tag sharepoint, hopefully with the correct metadata / description

@Yvand
Copy link
Author

Yvand commented Feb 5, 2025

@hemarina this is ready for your review

@v-xuto
Copy link
Member

v-xuto commented Feb 6, 2025

@Yvand
Copy link
Author

Yvand commented Feb 6, 2025

hello @v-xuto, I addressed both issues, please let me know if you have further questions

@v-xuto
Copy link
Member

v-xuto commented Feb 7, 2025

hello @v-xuto, I addressed both issues, please let me know if you have further questions

@Yvand We added relevant comments to these two issues. Please review.

@Yvand
Copy link
Author

Yvand commented Feb 7, 2025

Review completed on my side, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants