Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dapr PubSub template for Java applications on AKS and fix diagram… #155

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Dapr PubSub template for Java applications on AKS and fix diagram… #155

wants to merge 8 commits into from

Conversation

greenie-msft
Copy link

@greenie-msft greenie-msft commented Jun 6, 2023 •
edited
Loading

…s for other Dapr templates

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@greenie-msft
Add Dapr PubSub template for Java applications on AKS and fix diagram…
98630f3 
…s for other Dapr templates

Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Update author field
f27588c 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Add 7 more azd templates:
dd81773 
1 - Dapr Albums in ACA
6 - Functions with AI

Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
add ai tag to all AI templates
97b66c3 
Signed-off-by: Nick Greenfield <[email protected]>
@hemarina
Copy link
Contributor

hemarina commented Jun 8, 2023 •
edited
Loading

@v-xuto Could you validate and test these templates when you get a chance?

cc @rajeshkamal5050 @jongio

@v-xuto
Copy link
Member

v-xuto commented Jun 9, 2023

@v-xuto Could you validate and test these templates when you get a chance?

cc @rajeshkamal5050 @jongio

Sure, we will start testing these templates.

@jongio
Copy link
Member

jongio commented Jun 15, 2023

@greenie-msft - I see OPENAI_API_KEY in the readme, but I don't see it in bicep. https://github.com/Azure-Samples/function-csharp-ai-openai-chatgpt

Could you look into using azd env set OPENAI_API_KEY value, and then, read that value into main.parameter.json and then use it in your infra.

@v-xuto
Copy link
Member

v-xuto commented Jun 21, 2023 •
edited
Loading

@hemarina We have completed the testing of these templates and filed the following issues. Please review and resolve them.

@hemarina
Copy link
Contributor

@hemarina We have completed the testing of these templates and filed the following issues. Please review and resolve them.

@greenie-msft Would you mind taking a look at these issues? Some issues are simple changes like issue. Let me know if you have any questions.

@savannahostrowski savannahostrowski requested review from savannahostrowski and removed request for savannahostrowski August 3, 2023 17:37
@v-xuto
Copy link
Member

v-xuto commented Sep 5, 2023

@hemarina About template function-csharp-ai-textsummarize, issue Azure-Samples/function-csharp-ai-textsummarize#6 has been fixed. We continued to test and encountered two new issues, please review.

@hemarina
Copy link
Contributor

hemarina commented Nov 8, 2023 •
edited
Loading

@greenie-msft Would you mind taking a look at these issues in order for us to add templates to gallery?

@macromania
Copy link

Hi @hemarina & @greenie-msft,

This issue Azure-Samples/pubsub-dapr-aks-java#1 is now fixed. Hopefully the template can make into here. 😅 Please let me know if you'd require anything further.

Also, apologies for the delay 😇

@v-xuto
Copy link
Member

v-xuto commented Nov 22, 2023

@hemarina Currently the following issues have not been fixed.

@hemarina hemarina mentioned this pull request Nov 29, 2023
Merged
@hemarina
Update templates.json
be5f27d 
remove templates that passed the tests as they are added in PR 257
@hemarina
Copy link
Contributor

hemarina commented Nov 29, 2023 •
edited
Loading

@greenie-msft All other templates that passed the test were merged in PR #257. Please take a look at issues in function-csharp-ai-openai-chatgpt and containerapps-dapralbums. function-csharp-ai-textsummarize issues are not blocking as the template is already in gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savannahostrowski savannahostrowski savannahostrowski left review comments

@hemarina hemarina hemarina approved these changes

@gkulin gkulin Awaiting requested review from gkulin

@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050 rajeshkamal5050 is a code owner

Assignees

@greenie-msft greenie-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@greenie-msft @hemarina @v-xuto @jongio @macromania @savannahostrowski