Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF Module References #612

Closed
wants to merge 2 commits into from

Conversation

mbrat2005
Copy link
Contributor

Overview/Summary

PS C:\Users\mbratschun\repos\avdaccelerator\workload\terraform\greenfield\AADscenario> terraform init

Initializing the backend...
Initializing modules...
- personal in ..\..\modules\avd\personal
╷
│ Error: Module is incompatible with count, for_each, and depends_on
│ 
│   on main.tf line 68, in module "personal":
│   68:   depends_on     = [module.avdi.avdLocation]
│ 
│ The module at module.personal is a legacy module which contains its own local provider configurations, and so calls to it may not use the count, for_each, or depends_on arguments.
│ 
│ If you also control the module "../../modules/avd/personal", consider updating this module to instead expect provider configurations to be passed by its caller.
╵

This PR fixes/adds/changes/removes

  1. Updated commented module references to include /avd in paths
  2. Remove the empty local provider configuration in the personal module

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

image

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@jensheerin
Copy link
Contributor

hold merge

@danycontre
Copy link
Collaborator

@jensheerin please help us checking this one.

@jensheerin
Copy link
Contributor

@danycontre this will not be merged. The AVM module was used instead. Please close.

@danycontre danycontre closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants