New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CARML - AVM module transition complete #4541
base: main
Are you sure you want to change the base?
Conversation
The PR looks good, but given it's impact, I want to have a chance to talk with @eriqua first before merging it. as all other changes are removals, updates to the moved-to-avm.md file and updates to each module's readme.md file, which unfortuantely saw a lot more updates than it should as @matebarabas seems to have a markdown VSCode extension with table formatting enabled Not that it matters much at this point. He shall just not do it in AVM 😄 |
@matebarabas @AlexanderSehr I believe that before removing all modules we should deal with open PRs and make sure that relevant improvements are ported to AVM. |
modules/aad/domain-service/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of keeping the readmes here? I'd suggest to remove them as well.
Some of them will have broken links due to the removal of their child module readmes, as pointed out also by the broken links PR check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @matebarabas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline and agreed on removing readmes
I presume they'll simply show conflicts all over as they cannot update a file that doesn't exist |
Description
This PR leaves clear indications that the CARML to AVM module transition is complete and that only the AVM version of the modules will be maintained going forward.
Type of Change
Checklist