Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARML - AVM module transition complete #4541

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

matebarabas
Copy link
Collaborator

Description

This PR leaves clear indications that the CARML to AVM module transition is complete and that only the AVM version of the modules will be maintained going forward.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@matebarabas matebarabas self-assigned this May 1, 2024
@matebarabas matebarabas marked this pull request as ready for review May 3, 2024 04:36
@matebarabas matebarabas requested a review from a team as a code owner May 3, 2024 04:36
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented May 3, 2024

The PR looks good, but given it's impact, I want to have a chance to talk with @eriqua first before merging it.
@eriqua, the main file to review is pretty much only the readme.md in root,
image

as all other changes are removals, updates to the moved-to-avm.md file
image

and updates to each module's readme.md file, which unfortuantely saw a lot more updates than it should as @matebarabas seems to have a markdown VSCode extension with table formatting enabled
image

Not that it matters much at this point. He shall just not do it in AVM 😄

@eriqua
Copy link
Contributor

eriqua commented May 12, 2024

The PR looks good, but given it's impact, I want to have a chance to talk with @eriqua first before merging it. @eriqua, the main file to review is pretty much only the readme.md in root, image

as all other changes are removals, updates to the moved-to-avm.md file image

and updates to each module's readme.md file, which unfortuantely saw a lot more updates than it should as @matebarabas seems to have a markdown VSCode extension with table formatting enabled image

Not that it matters much at this point. He shall just not do it in AVM 😄

@matebarabas @AlexanderSehr I believe that before removing all modules we should deal with open PRs and make sure that relevant improvements are ported to AVM.
Not sure how PR diffs will render after removing their target code.
I don't see many opened so it will hopefully be quick

Copy link
Contributor

@eriqua eriqua May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of keeping the readmes here? I'd suggest to remove them as well.

Some of them will have broken links due to the removal of their child module readmes, as pointed out also by the broken links PR check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline and agreed on removing readmes

@AlexanderSehr
Copy link
Contributor

The PR looks good, but given it's impact, I want to have a chance to talk with @eriqua first before merging it. @eriqua, the main file to review is pretty much only the readme.md in root, image
as all other changes are removals, updates to the moved-to-avm.md file image
and updates to each module's readme.md file, which unfortuantely saw a lot more updates than it should as @matebarabas seems to have a markdown VSCode extension with table formatting enabled image
Not that it matters much at this point. He shall just not do it in AVM 😄

@matebarabas @AlexanderSehr I believe that before removing all modules we should deal with open PRs and make sure that relevant improvements are ported to AVM. Not sure how PR diffs will render after removing their target code. I don't see many opened so it will hopefully be quick

I presume they'll simply show conflicts all over as they cannot update a file that doesn't exist

@AlexanderSehr AlexanderSehr linked an issue May 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: AVM alignment tracker
3 participants