Skip to content

[ARO-15117] MIWI e2e - remove disk-csi missing permissions workaround #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

cadenmarchese
Copy link
Collaborator

@cadenmarchese cadenmarchese commented Mar 31, 2025

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-15117

What this PR does / why we need it:

Previously we included this code because the disk-csi built-in role was missing a permission, and adding actions to built-in roles takes a while.

Now, the built-in has the permission, so we can safely remove this code:

az role definition list --name "Azure Red Hat OpenShift Disk Storage Operator"
[
  {
    "assignableScopes": [
      "/"
    ],
    "createdBy": null,
    "createdOn": "2024-01-30T16:11:37.947432+00:00",
    "description": "Install Container Storage Interface (CSI) drivers that enable your cluster to use Azure Disks. Set OpenShift cluster-wide storage defaults to ensure a default storageclass exists for clusters.",
    "id": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/providers/Microsoft.Authorization/roleDefinitions/5b7237c5-45e1-49d6-bc18-a1f62f400748",
    "name": "5b7237c5-45e1-49d6-bc18-a1f62f400748",
    "permissions": [
      {
        "actions": [
          "Microsoft.Compute/virtualMachines/write",
          "Microsoft.Compute/virtualMachines/read",
          "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/write",
          "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/read",
          "Microsoft.Compute/virtualMachineScaleSets/read",
          "Microsoft.Compute/snapshots/write",
          "Microsoft.Compute/snapshots/read",
          "Microsoft.Compute/snapshots/delete",
          "Microsoft.Compute/locations/operations/read",
          "Microsoft.Compute/locations/DiskOperations/read",
          "Microsoft.Compute/disks/write",
          "Microsoft.Compute/disks/read",
          "Microsoft.Compute/disks/delete",
          "Microsoft.Compute/disks/beginGetAccess/action",
          "Microsoft.Compute/diskEncryptionSets/read",
          "Microsoft.Resources/subscriptions/resourceGroups/read"
        ],
        "condition": null,
        "conditionVersion": null,
        "dataActions": [],
        "notActions": [],
        "notDataActions": []
      }
    ],
    "roleName": "Azure Red Hat OpenShift Disk Storage Operator",
    "roleType": "BuiltInRole",
    "type": "Microsoft.Authorization/roleDefinitions",
    "updatedBy": null,
    "updatedOn": "2025-03-28T17:59:48.057794+00:00"
  }
]

Test plan for issue:

  • CI, regular e2e
  • MIWI e2e (/azp run e2e)

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@cadenmarchese
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cadenmarchese
Copy link
Collaborator Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kimorris27 kimorris27 merged commit 9b4a68e into master Apr 8, 2025
23 checks passed
@kimorris27 kimorris27 deleted the cadenmarchese/ARO-15117/remove-e2e-workaround branch April 8, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants