-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aks name refactor #1170
base: main
Are you sure you want to change the base?
Aks name refactor #1170
Conversation
435a2d2
to
d80948c
Compare
Please rebase pull request. |
d80948c
to
618987a
Compare
618987a
to
e819070
Compare
This change is a breaking change, the errors in the "what-if" look to be expected. We will need to fully redeploy environments ARO HCP Integrated DEV Bicep What-If / what-if (pull_request)
ARO HCP Service PR Check / service_cluster_pr_check (pull_request) These checks fail because the resource does not exist, expected due to the name change.
|
340f96a
to
f37daf9
Compare
What this PR does
Refactors clusters names so they are unique. This change was mostly driven from the requirement of needing unique metrics as Azure Managed Prometheus does not support adding additional labels to default metrics (api server, node, etc) and there is no "resource_group" label to uniquely identity a metric.
How was it tested?
I was able to provision all the infrastructure for a personal dev cluster and create a hosted cluster.
Jira:
Link to demo recording:
Special notes for your reviewer