Policy Baseline Exemption Logic Needs to Live in ALZ Repo and a Flag for Azure Firewall Policy #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oZakari
reviewed
Apr 18, 2024
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
oZakari
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Hey @VeronicaSea, thanks for submitting this PR, let me know if you have any questions as you're going over my comments.
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
|
Hey @VeronicaSea, feel free to just ping me when you ready for me to re-review. Have a good week! |
Yes, it is ready for your review. Please review it and thanks. |
VeronicaSea
changed the title
oZakari
requested changes
May 7, 2024
There was a problem hiding this comment.
Thanks @VeronicaSea, along with the changes I suggested and/or requested. Could we also ensure that the exemptions module folder contains all of the files documented here: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#constructing-a-bicep-module.
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
…DefaultPolicyAssignments.bicep Co-authored-by: Zach Trocinski <[email protected]>
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch