More changes

.github/workflows/ci-build.yml

@@ -45,15 +45,7 @@ jobs:
           make lint
 
       - name: "Run all unit tests"
-        run: make test-reports
-
-      # Very optional - upload of test results
-      - name: "Upload test reports to Azure"
-        if: ${{ success() || failure() }}
-        run: |
-          az storage blob upload-batch --account-name $STORAGE_ACCT_NAME --account-key "${{ secrets.STORAGE_KEY }}" \
-             --source ./output --destination \$web/${{ github.run_id }} --no-progress > /dev/null
-          echo -e "📜🌍 Test reports uploaded and viewable here - https://$STORAGE_ACCT_NAME.z6.web.core.windows.net/${{ github.run_id }}/"
+        run: make test
 
   # ===== Build container images ======
   build-images:

.golangci.yaml

@@ -1,24 +1,20 @@
 # =================================================================
 # An opinionated config for linting Go code with golangci-lint
-# See https://golangci-lint.run/usage/linters 
+# See https://golangci-lint.run/usage/linters
 # =================================================================
 
 linters:
   enable:
-    - revive      # Replacement for golint
-    - gofmt       # Runs gofmt as part of the linter
-    #- gosec       # Find security issues
-    - wsl         # Whitespace style enforcer, a matter of taste
-    - stylecheck  # A few Go style rules
-    - nosnakecase # We are not writing Python here
-    - misspell    # Find misspelled words
-    - cyclop      # Find cyclomatic complexity
-    - gocyclo     # Also find cyclomatic complexity
-    - bodyclose   # Check for HTTP body close errors
-    - nilerr      # Find bad nil/err handling
-    - nilnil      # Also find bad nil/err handling
-    #- tagliatelle # Find badly named struct tags
-    #- gomnd       # Find magic numbers, enable at your peril
+    - revive # Replacement for golint
+    - gofmt # Runs gofmt as part of the linter
+    - wsl # Whitespace style enforcer, a matter of taste
+    - stylecheck # A few Go style rules
+    - misspell # Find misspelled words
+    - cyclop # Find cyclomatic complexity
+    - gocyclo # Also find cyclomatic complexity
+    - bodyclose # Check for HTTP body close errors
+    - nilerr # Find bad nil/err handling
+    - nilnil # Also find bad nil/err handling
 
 linters-settings:
   misspell:
@@ -33,7 +29,7 @@ linters-settings:
         yaml: goCamel
 
   revive:
-    severity: error 
+    severity: error
     enable-all-rules: false
     confidence: 0.5
     rules:
@@ -42,4 +38,4 @@ linters-settings:
       # And https://golangci-lint.run/usage/linters/#revive
       - name: line-length-limit
         severity: error
-        arguments: [160]
+        arguments: [160]

Makefile

@@ -30,16 +30,6 @@ test:  ## 🎯 Unit tests for services and snapshot tests for SPA frontend
 	go test -v -count=1 ./$(SERVICE_DIR)/...
 	@cd $(FRONTEND_DIR); NODE_ENV=test npm run test -- --ci
 
-test-reports: $(FRONTEND_DIR)/node_modules  ## 📜 Unit tests with coverage and test reports (deprecated)
-	@rm -rf $(OUTPUT_DIR) && mkdir -p $(OUTPUT_DIR)
-	@which gotestsum || go install gotest.tools/gotestsum
-	gotestsum --junitfile $(OUTPUT_DIR)/unit-tests.xml ./$(SERVICE_DIR)/... --coverprofile $(OUTPUT_DIR)/coverage
-	cd $(FRONTEND_DIR); NODE_ENV=test npm run test -- --ci
-	./$(FRONTEND_DIR)/node_modules/.bin/xunit-viewer -r $(OUTPUT_DIR)/unit-tests.xml -o $(OUTPUT_DIR)/unit-tests.html
-	./$(FRONTEND_DIR)/node_modules/.bin/xunit-viewer -r $(OUTPUT_DIR)/unit-tests-frontend.xml -o $(OUTPUT_DIR)/unit-tests-frontend.html
-	go tool cover -html=$(OUTPUT_DIR)/coverage -o $(OUTPUT_DIR)/cover.html
-	cp testing/reports.html $(OUTPUT_DIR)/index.html
-
 bundle: $(FRONTEND_DIR)/node_modules  ## 💻 Build and bundle the frontend Vue SPA
 	cd $(FRONTEND_DIR); npm run build
 	cd $(SERVICE_DIR)/frontend-host; go build

cmd/cart/impl/impl.go

@@ -188,7 +188,7 @@ func makeID(length int) string {
 	id := ""
 	possible := "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
 
-	rand.Seed(time.Now().UnixNano())
+	rand.New(rand.NewSource(time.Now().UnixNano()))
 
 	for i := 0; i < length; i++ {
 		id += string(possible[rand.Intn(len(possible)-1)])