Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable key auth for Azure Document Intelligence #1629

Merged
merged 1 commit into from
May 28, 2024

Conversation

pamelafox
Copy link
Collaborator

@pamelafox pamelafox commented May 17, 2024

Purpose

This PRs disable key-based API access ("local auth") for Document Intelligence, which is preferred from a security standpoint. We have seen that developers have wanted to keep key access for their OpenAI accounts and have been asked to make it an option, should I also make this an option (via a bool parameter like enableDocIntelligenceKeys defaulting to false?)

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No - at least it shouldnt be for our core repo

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@mattgotteiner
Copy link
Collaborator

We have seen that developers have wanted to keep key access for their OpenAI accounts and have been asked to make it an option, should I also make this an option (via a bool parameter like enableDocIntelligenceKeys defaulting to false?)

I think we can consider making this an option if we get feedback, but I'm OK merging as is

@pamelafox pamelafox merged commit f11423a into Azure-Samples:main May 28, 2024
11 checks passed
@pamelafox pamelafox deleted the localauth branch May 28, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants