Add clickable help icons for developer settings #1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1334
This is an alternative to #1487 which instead adds clickable help icons. I was unable to get the tooltips to pop up on my machine (not sure if it's a Mac thing or a user error?) and clickable icons are generally more accessible, so I made a branch to try this possibility.
I had to move some of the fields over when the components did not support renderLabel, like SpinButton and ChoiceGroup, but the end result is very similar functionality-wise.
Note that we have a HUGE amount of repeated code between Chat.tsx and Ask.tsx. We could potentially make a DeveloperSettings component that took all the defaults/callbacks. I had to do a lot of repetitive updating across both.
Also realized that our VectorFields setting is weird- it's a list, but we never send multiple values. I think it should just be a string. But that's for another day.
Screenshots:
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added lines: No, since coverage doesnt include JS codepython -m mypy
to check for type errorsruff
andblack
manually on my code.