-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various internal machine api improvements #900
Open
Swedz
wants to merge
18
commits into
AztechMC:1.21.x
Choose a base branch
from
Swedz:improve-machine-model-api
base: 1.21.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swedz
changed the title
Improve internal machine model API
Various internal machine api improvements
Sep 25, 2024
It might make sense to also add the |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves model API to allow so it is more extensible
Use
ResourceLocation
for machine casing ids. If no namespace is provided, it defaults to MI's namespaceWiden visibility and overridability of some methods and variables in
ShapeMatcher
,CasingComponent
, andMultiblockMachineBlockEntity
Make the
CableTier
ofEnergyHatch
andCasingComponent
accessibleImproves shape matcher API to allow for machines to define their own custom shape matcher and also standardizes the various methods triggered relating to multiblock shape matching (lots of duplicate code is removed)
Improve the internal storing of components such that they can be accessed and modified in the same way for both and includes some extra utility methods (I think I covered all reasonable use cases)
Allow for vertical orientations in
OrientationComponent
Allow
BackgroundRenderedSlot
to override the atlas used to render them