Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with using custom server commands in es_delayed and es… #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThaPwned
Copy link
Contributor

@ThaPwned ThaPwned commented Jan 8, 2021

…_soon

Using es_(x)delayed or es_(x)soon with custom server commands would ignore the 1st argument of the custom command

…_soon

Using es_(x)delayed or es_(x)soon with custom server commands would ignore the 1st argument of the custom command
@Ayuto Ayuto linked an issue Jan 31, 2021 that may be closed by this pull request
@NosferatuJoe
Copy link
Contributor

This issue is still present btw. If I don't overwrite a file, the wcs mod is unusable with the emulator.
If more info is needed I will gladly test or provide a way to reproduce the issue.

@Ayuto
Copy link
Owner

Ayuto commented Feb 9, 2021

Yes, because I haven't merged the code yet.

@NosferatuJoe
Copy link
Contributor

Yes, because I haven't merged the code yet.

Ok, sorry for the spam. ^^

ManifestManah added a commit to ManifestManah/EventScripts-Emulator-For-WCS that referenced this pull request Apr 8, 2021
Fixed a problem which prevented the usage of es_delayed and es_soon for executing delayed custom command.

Without this fix a lot of WC:S content will not work as intended.

The original fix was shared ThaPwned and found here:
Ayuto#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with Es_delayeds execution of commands
3 participants