Skip to content

[AXA.fr] [Espace Client] [Organisme] Evolutions du composant Modal #824 #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 2, 2025
Merged

[AXA.fr] [Espace Client] [Organisme] Evolutions du composant Modal #824 #1184

merged 21 commits into from
Jul 2, 2025

Conversation

abderrahman-fawzy-acn-axa
Copy link
Contributor

No description provided.

@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa force-pushed the feature/apollo-modal branch 3 times, most recently from 053c24d to bb4ce6e Compare May 8, 2025 13:02
@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa marked this pull request as ready for review May 8, 2025 13:03
@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa force-pushed the feature/apollo-modal branch 2 times, most recently from b49eeb9 to 10efbf3 Compare May 13, 2025 06:44
samuel-gomez-axa
samuel-gomez-axa reviewed Jun 2, 2025
View reviewed changes
@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa linked an issue Jun 3, 2025 that may be closed by this pull request
[AXA.fr] [Espace Client] [Organisme] Evolutions du composant Modal #824
Closed
@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa force-pushed the feature/apollo-modal branch 4 times, most recently from 86bf9dd to 80203eb Compare June 4, 2025 09:53
@samuel-gomez-axa
Copy link
Contributor

il y a un souci sur le hover de la croix de fermeture
https://67cef00364c94d65367d817c-fqeauzboud.chromatic.com/?path=/story/components-modal--modal-content&globals=viewport:desktop

@abderrahman-fawzy-acn-axa
Copy link
Contributor Author

abderrahman-fawzy-acn-axa commented Jun 5, 2025 •
edited
Loading

il y a un souci sur le hover de la croix de fermeture https://67cef00364c94d65367d817c-fqeauzboud.chromatic.com/?path=/story/components-modal--modal-content&globals=viewport:desktop

@samuel-gomez-axa je crois que c'est lié au composant ClickIcon. il y a le même comportement ici https://67cef00364c94d65367d817c-fqeauzboud.chromatic.com/?path=/docs/components-clickicon--clickicon&globals=viewport:desktop

@samuel-gomez-axa
Copy link
Contributor

il y a un souci sur le hover de la croix de fermeture https://67cef00364c94d65367d817c-fqeauzboud.chromatic.com/?path=/story/components-modal--modal-content&globals=viewport:desktop

@samuel-gomez-axa je crois que c'est lié au composant ClickIcon. il y a le même comportement ici https://67cef00364c94d65367d817c-fqeauzboud.chromatic.com/?path=/docs/components-clickicon--clickicon&globals=viewport:desktop

ok, @abderrahman-fawzy-acn-axa il faut créer une issue à ce sujet

GuillaumeKESTEMAN
GuillaumeKESTEMAN reviewed Jun 23, 2025
View reviewed changes
Abderrahman FAWZY DEV added 20 commits June 25, 2025 16:52
feat(apollo): added useHasScroll hook
e647f33
feat(apollo,look&feel): évolution du composant modal
06e381d
feat(apollo,look&feel): ajout des tests du composant modal
0b6a9a7
feat(apollo): ajout des stories du composant modal
c114fcb
feat(look&feel): suppression du code du composant modal et réexportat…
e51169a 
…ion d'apollo
feat(look&feel): encapsulation des stories du composant modal dans so…
ad633ba 
…n folder
style(apollo,look&feel): defined overlay color in modal lf css
5c22b88
revert "feat(look&feel): suppression du code du composant modal et ré…
c51b61c 
…exportation d'apollo"

This reverts commit e5280d2.
feat(look&feel): mention du composant en deprecated et suggestion d'u…
2dd7e37 
…tiliser la version apollo
feat(apollo,look&feel): retours pr
6eb228a
revert "feat(look&feel): encapsulation des stories du composant modal…
8e126ea 
… dans son folder"

This reverts commit 3b28b94.
feat(look&feel): ajout des stories de la modal venant d'apollo
c3bfadd
style(apollo,look&feel): modification du préfixe af-modal* par af-apo…
5dbdfd0 
…llo-modal*

pour éviter l'entremêlement des styles apollo et look-and-feel
style(apollo,look&feel): retour sur la config legacy de color-functio…
f03e0be 
…n-notation
feat(look&feel): retour pr story
58e833a
test(apollo): corrected failing build
fa257a1
feat(apollo): fixed errors in modal stories
b9ed4cd
feat(look&feel): fixed errors in modal stories and importing modal fr…
20be8c1 
…om apollo/lf
test(apollo): fixed modal test
d143f1d
feat(apollo,look&feel): retour pr sur les stories et tests
67cfe29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@samuel-gomez-axa samuel-gomez-axa merged commit 1d0075a into main Jul 2, 2025
7 of 11 checks passed
@samuel-gomez-axa samuel-gomez-axa deleted the feature/apollo-modal branch July 2, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-gomez-axa samuel-gomez-axa samuel-gomez-axa approved these changes

@GuillaumeKESTEMAN GuillaumeKESTEMAN GuillaumeKESTEMAN approved these changes

@tejb-axa tejb-axa tejb-axa approved these changes

@pjbeaugendre pjbeaugendre pjbeaugendre left review comments

@neehal-axa neehal-axa neehal-axa left review comments

Assignees

@abderrahman-fawzy-acn-axa abderrahman-fawzy-acn-axa

Labels
Apollo AXA.fr component component needs to be worked on look'n feel (Espace Client) molecule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AXA.fr] [Espace Client] [Organisme] Evolutions du composant Modal
6 participants
@abderrahman-fawzy-acn-axa @samuel-gomez-axa @GuillaumeKESTEMAN @pjbeaugendre @neehal-axa @tejb-axa